[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #27209] tcp_input discards frames even though they are
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window |
Date: |
Tue, 11 Aug 2009 14:11:21 +0000 |
User-agent: |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; de; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 |
Follow-up Comment #20, bug #27209 (project lwip):
Reading the patch, I think we can drop the second "if
(TCPH_FLAGS(inseg.tcphdr) & TCP_FIN)" (inside the "else if
(TCP_SEQ_LEQ(pcb->ooseq->tcphdr->seqno, seqno + tcplen))" block) since the FIN
flag has already been checked above.
Also, I'd strongly encourage using braces for every if block (even if the
block is a single line) to prevent future developer's changes from forgetting
them when adding a line.
Last, only to make sure I understood the patch correctly, am I right that it
implements solution 2) of comment #9?
Unfortunately, I cannot really test the patch currently, but from reading,
the rest seems OK.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?27209>
_______________________________________________
Nachricht geschickt von/durch Savannah
http://savannah.nongnu.org/
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, (continued)
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Åke Rehnman, 2009/08/10
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Kieran Mansley, 2009/08/10
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Simon Goldschmidt, 2009/08/10
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Åke Rehnman, 2009/08/10
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Kieran Mansley, 2009/08/11
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Kieran Mansley, 2009/08/11
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Kieran Mansley, 2009/08/11
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Åke Rehnman, 2009/08/11
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Kieran Mansley, 2009/08/11
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Kieran Mansley, 2009/08/11
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window,
Simon Goldschmidt <=
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Kieran Mansley, 2009/08/11
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Åke Rehnman, 2009/08/11
- [lwip-devel] [bug #27209] tcp_input discards frames even though they are within the announced window, Kieran Mansley, 2009/08/12