[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #27504] tcp_enqueue wrongly concatenates segments whic
From: |
Jakob Stoklund Olesen |
Subject: |
[lwip-devel] [bug #27504] tcp_enqueue wrongly concatenates segments which are not consecutive when retransmitting unacked segments |
Date: |
Wed, 23 Sep 2009 10:32:53 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.14) Gecko/2009090216 Ubuntu/9.04 (jaunty) Firefox/3.0.14 |
Follow-up Comment #1, bug #27504 (project lwip):
The patch looks good to me.
I am a little worried about the tcp_rexmit behaviour. I thought that unacked
+ unsent were supposed to form a continuous, monotonic sequence of segments?
Apparently, so did tcp_enqueue().
Note that tcp_rexmit_rto preserves this invariant as well.
Could tcp_rexmit perhaps call tcp_output_segment directly rather than mucking
about with the queues?
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?27504>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/