[lwip-devel] [bug #26251] RST process in TIME_WAIT TCP state

[Oleg Tyshev]

Follow-up Comment #3, bug #26251 (project lwip):

OK, with RST agree with you:
ignore means send nothing.

Now each data packet in TIME_WAIT state will be acknowledged.
tcp_timewait_input() -> tcp_output()

In tcp_output()

if (pcb->flags & TF_ACK_NOW &&
    (seg == NULL || ... ) {
   ....
   tcphdr->ackno = htonl(pcb->rcv_nxt);
   ....
 ip_output(p ...);
 return ERR_OK;
}

In TIME_WAIT we already received all data and seems to me rcv_nxt should not
be changed.

---

Some general notes about tcp_timewait_input() function:

We have following implementation for tcp_ack_now
#define tcp_ack_now(pcb) (pcb)->flags |= TF_ACK_NOW; 
                         tcp_output(pcb)
It means for (tcplen > 0)
 function tcp_output would be called twice.
It is not bad, but we can avoid it.

  if (tcplen > 0) {
-    tcp_ack_now(pcb);
+    pcb->flags |= TF_ACK_NOW;
  }
  return tcp_output(pcb);


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26251>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/