[lwip-devel] [patch #6901] PPP callback with netif

[Simon Goldschmidt]

Update of patch #6901 (project lwip):

                  Status:                 Wont Do => Need Info              
             Open/Closed:                  Closed => Open                   

    _______________________________________________________

Follow-up Comment #3:

It's great to see someone's actually using lwIP PPP :-)

> Can someone reopen this bug and schedule it for lwip 1.4?

For implementing the originally requested change or to fix setting the netif
status/link callbacks?

> [..]
> // --> this is missing
> #if LWIP_NETIF_STATUS_CALLBACK
> netif_set_status_callback(netif, pppnetif_status_callback);
> #endif
> #if LWIP_NETIF_LINK_CALLBACK
> netif_set_link_callback(netif, pppnetif_link_callback);
> #endif
> // <--
> return ERR_OK;
> }
> 
> Can someone confirm this is OK?

I would think so, although (unfortunately) I can't confirm it as I'm not
totally familiar with the PPP code myself.

Re: "Some notes about lwip 1.3.2 RC1"
> *line 1388: add a function call
> 
> pc->if_up = 0;
> netif_set_down(&pc->netif); // <-- this line is missing
> netif_remove(&pc->netif);

Looks OK, too (and also relevant to this bug/patch).

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6901>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/