[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #6901] PPP callback with netif
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [patch #6901] PPP callback with netif |
Date: |
Thu, 29 Oct 2009 17:57:39 +0000 |
User-agent: |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; de; rv:1.9.1.4) Gecko/20091016 Firefox/3.5.4 |
Update of patch #6901 (project lwip):
Status: Wont Do => Need Info
Open/Closed: Closed => Open
_______________________________________________________
Follow-up Comment #3:
It's great to see someone's actually using lwIP PPP :-)
> Can someone reopen this bug and schedule it for lwip 1.4?
For implementing the originally requested change or to fix setting the netif
status/link callbacks?
> [..]
> // --> this is missing
> #if LWIP_NETIF_STATUS_CALLBACK
> netif_set_status_callback(netif, pppnetif_status_callback);
> #endif
> #if LWIP_NETIF_LINK_CALLBACK
> netif_set_link_callback(netif, pppnetif_link_callback);
> #endif
> // <--
> return ERR_OK;
> }
>
> Can someone confirm this is OK?
I would think so, although (unfortunately) I can't confirm it as I'm not
totally familiar with the PPP code myself.
Re: "Some notes about lwip 1.3.2 RC1"
> *line 1388: add a function call
>
> pc->if_up = 0;
> netif_set_down(&pc->netif); // <-- this line is missing
> netif_remove(&pc->netif);
Looks OK, too (and also relevant to this bug/patch).
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?6901>
_______________________________________________
Nachricht geschickt von/durch Savannah
http://savannah.nongnu.org/
- [lwip-devel] [patch #6901] PPP callback with netif, Simon Goldschmidt, 2009/10/16
- [lwip-devel] [patch #6901] PPP callback with netif, Iordan Neshev, 2009/10/29
- [lwip-devel] [patch #6901] PPP callback with netif,
Simon Goldschmidt <=
- [lwip-devel] [patch #6901] PPP callback with netif, Simon Goldschmidt, 2009/10/29
- [lwip-devel] [patch #6901] PPP callback with netif, Iordan Neshev, 2009/10/30
- [lwip-devel] [patch #6901] PPP callback with netif, Kieran Mansley, 2009/10/30
- [lwip-devel] [patch #6901] PPP callback with netif, Simon Goldschmidt, 2009/10/30
- [lwip-devel] [patch #6901] PPP callback with netif, Iordan Neshev, 2009/10/30
- [lwip-devel] [patch #6901] PPP callback with netif, Kieran Mansley, 2009/10/30
- [lwip-devel] [patch #6901] PPP callback with netif, Simon Goldschmidt, 2009/10/30
- [lwip-devel] [patch #6901] PPP callback with netif, Iordan Neshev, 2009/10/30