[lwip-devel] [patch #6969] PPP: missing PAP authentication UNTIMEOUT

[Iordan Neshev]

Follow-up Comment #1, patch #6969 (project lwip):

Yesterday I sent a mail to one of the pppd developers
(address@hidden) about this patch. This is his response:

"Your proposed fix looks reasonable, although I would probably put the
UNTIMEOUT() just before the assignment to 
u->us_clientstate."

This is not submitted yet to the pppd bugtracker.
I think this is the solution of:

http://ppp.samba.org/cgi-bin/ppp-bugs/incoming?id=1163;user=guest
https://savannah.nongnu.org/bugs/?13315

As Paul suggested, I propose to add
UNTIMEOUT(upap_timeout, u); /* Cancel timeout */
just before u->us_clientstate = UPAPCS_OPEN;

I think this should go into lwip 1.3.2. Any objections?



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6969>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/