[lwip-devel] [bug #27352] Change ip_addr from struct to typedef (u32_t)

[Stephane Lesage]

Follow-up Comment #29, bug #27352 (project lwip):


I looked at the compiled code and it looks ok. The access is compiled
accordingly to the packed attribute of the pointer. So this is better now (we
still need the copies), but there's room for improvement:

- all packed structures seem to be fine with word alignment, I tested it
successfully. some structures like udp_hdr even don't need packing (assuming
pointers are even which should always be the case, no ?)...
or we could add the min alignment as a parameter of the PACK_STRUCT macros

- define IP4_ADDR() and ip4_addrX() macros directly according to endianness,
not using htonl()


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?27352>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/