lwip-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #28798] IGMP "Max Response Time" processing bug

From: Stephane Lesage
Subject: [lwip-devel] [bug #28798] IGMP "Max Response Time" processing bug
Date: Mon, 08 Feb 2010 18:31:38 +0000
User-agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 2.0.50727; .NET CLR 1.1.4322; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729) 
Follow-up Comment #6, bug #28798 (project lwip):

>Could you please separate coding style functions from bugfixes from other
improvements next time?

ok

>I changed the check in igmp_delaying_member() to compare igmp->timer to
(maxresp/2), not maxresp, since we set that later. In general, why do we use
maxresp/2 here, anyway?

For historic reasons, there was not LWIP_RAND() function, so it was set
arbitrarily to maxresp/2.

When we changed to use random delays inside igmp_start_timer(),
we forgot the change the call to that function.



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?28798>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/
reply via email to
[Prev in Thread] Current Thread [Next in Thread]