[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [bug #28917] ICMP STATS improvement
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [bug #28917] ICMP STATS improvement |
Date: |
Tue, 16 Feb 2010 20:38:44 +0000 |
User-agent: |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 |
Follow-up Comment #1, bug #28917 (project lwip):
Point 2 is OK for me - although I'd leave away the "not supported" message:
if an echo reply is received, this means an echo request has been sent. This
can only be done using a raw PCB, so the echo reply will be parsed by that raw
PCB, too -> no need to issue a warning.
-> checked in - thanks for reporting
Point 1 is a different thing though: I'd prefer to not include that: raw
should not modify the ICMP stats. Instead, I'd rather add a function
icmp_send() to icmp.c that can send echo requests and increases the xmit stats
counter.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/bugs/?28917>
_______________________________________________
Nachricht geschickt von/durch Savannah
http://savannah.nongnu.org/