lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #7130] mib2.c: remove meaningless const qualifiers


From: Bill Auerbach
Subject: [lwip-devel] [patch #7130] mib2.c: remove meaningless const qualifiers
Date: Fri, 26 Mar 2010 14:01:06 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)

Follow-up Comment #15, patch #7130 (project lwip):

It's not a syntax error - it's a semantic error that some compilers have
decided to warn about an unnecessary pointer qualifier.  Just like some
compilers say the & on a function is not needed and others don't.

This construct (initializer) is NOT portable.  There should be a struct with
the common area up front and a union of structs to make the nodes different
based on that MB_NODE_xxx goodie.  This probably works because the structs
start out the same and are pointers, but I wouldn't have done it this way.

I don't insist anyone change it either :) Unless someone shows up and says it
won't work this way on their platform.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7130>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]