[lwip-devel] RE: lwip-devel Digest, Vol 75, Issue 1

[Wilson, Dave (Stellaris S/W)]

Jon,

  The "if(i == g_iNumCGIs)" test checks to see if we fell out of the end of the 
loop without processing anything. In this case, the URI isn't for one of the 
CGI handlers so it's treated normally. Looking at the code you added to the 
note, it does seem that the bracing is wrong since this block should occur 
within the "if(g_iNumCGIs && g_pCGIs)" section.

  Regards,

Dave Wilson
________________________________________
From: address@hidden address@hidden On Behalf Of address@hidden address@hidden
Sent: Sunday, September 05, 2010 11:01 AM
To: address@hidden
Subject: lwip-devel Digest, Vol 75, Issue 1

Send lwip-devel mailing list submissions to
        address@hidden

To subscribe or unsubscribe via the World Wide Web, visit
        http://lists.nongnu.org/mailman/listinfo/lwip-devel
or, via email, send a message with subject or body 'help' to
        address@hidden

You can reach the person managing the list at
        address@hidden

When replying, please edit your Subject line so it is more specific
than "Re: Contents of lwip-devel digest..."


Today's Topics:

   1. [bug #30963] httpd suspect behavior (Jon H. Peterson)


----------------------------------------------------------------------

Message: 1
Date: Sat, 04 Sep 2010 20:53:39 +0000
From: "Jon H. Peterson" <address@hidden>
Subject: [lwip-devel] [bug #30963] httpd suspect behavior
To: "Jon H. Peterson" <address@hidden>, address@hidden
Message-ID: <address@hidden>
Content-Type: text/plain;charset=UTF-8


URL:
  <http://savannah.nongnu.org/bugs/?30963>

                 Summary: httpd suspect behavior
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jonp
            Submitted on: Sat 04 Sep 2010 08:53:38 PM GMT
                Category: None
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release:
            lwIP version: Other

    _______________________________________________________

Details:

v1.3.2
if the if statement,  if(g_iNumCGIs && g_pCGIs), fails, then the if below,
if(i == g_iNumCGIs), is problematic (since i was never set by the loop) and
the Null that was inserted at params may not be replaced....i supposed this
really shouldn't happen, but users do make mistakes (hard to believe). not
sure i understand what the if(i == g_iNumCGIs) is supposed to do?
jon


  /* Does the base URI we have isolated correspond to a CGI handler? */
          if(g_iNumCGIs && g_pCGIs) {
            for(i = 0; i < g_iNumCGIs; i++) {
              if(strcmp(uri, g_pCGIs[i].pcCGIName) == 0) {
                /*
                 * We found a CGI that handles this URI so extract the
                 * parameters and call the handler.
                 */
                 count = extract_uri_parameters(hs, params);
                 uri = g_pCGIs[i].pfnCGIHandler(i, count, hs->params,
                                                hs->param_vals);
                 break;
              }
            }

            /* Did we handle this URL as a CGI? If not, reinstate the
             * original URL and pass it to the file system directly. */
            if(i == g_iNumCGIs)
            {
              /* Replace the ? marker at the beginning of the parameters */
              if(params) {
                 params--;
                *params = '?';
              }




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?30963>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




------------------------------

_______________________________________________
lwip-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/lwip-devel


End of lwip-devel Digest, Vol 75, Issue 1
*****************************************