[lwip-devel] [bug #31701] Error return value from dns_gethostbyname() doesn't match documentation

[David Empson]

URL:
  <http://savannah.nongnu.org/bugs/?31701>

                 Summary: Error return value from dns_gethostbyname() doesn't
match documentation
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: dempson
            Submitted on: Fri Nov 19 10:58:04 2010
                Category: None
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:

The comments for netconn_gethostbyname() indicate that a return value of
ERR_ARG is used for "dns client not initialized or invalid hostname".

The actual implementation in dns.c function dns_gethostbyname() is returning
ERR_VAL if dns_init() was not called, or either the hostname or IP address
pointer arguments are invalid.

I think dns_gethostbyname() should be corrected to return ERR_ARG instead of
ERR_VAL for these errors.

It may also be worth listing the ERR_ARG return value in the comment block
preceding dns_gethostbyname().

netconn_gethostbyname() can also return ERR_VAL for an timeout or other error
from the DNS server, so at present this return value is ambiguous.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?31701>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/