Re: [lwip-devel] Converting to git

[Wojciech A. Koszek]

Dnia 26-07-2011 o 19:24:34 address@hidden <address@hidden> napisał(a):

> I've made the function static if not exported in pbuf.h, could you try  
> if that fixes GCC's warning?

Sorry for the delay Simon.

I mentioned that timers.c has the call to this function, so "static" may  
not
be the best way to go:

140 cc -g -Wall -pedantic -Dopenbsd -DIPv4 -Os -fpack-struct -DLWIP_DEBUG  
-I../../../../src/include -I../../../../ports/unix/include  
-I../../../../src/include/ipv4 -I../../../../src/include/ipv6 -I.  
-I../../../../apps/snmp_private_mib -c     ../../../../src/core/init.c
141 cc -g -Wall -pedantic -Dopenbsd -DIPv4 -Os -fpack-struct -DLWIP_DEBUG  
-I../../../../src/include -I../../../../ports/unix/include  
-I../../../../src/include/ipv4 -I../../../../src/include/ipv6 -I.  
-I../../../../apps/snmp_private_mib -c     ../../../../src/core/timers.c
142 ../../../../src/core/timers.c: In function ‘sys_check_timeouts’:
143 ../../../../src/core/timers.c:433:7: warning: implicit declaration of  
function ‘pbuf_free_ooseq’
144 cc -g -Wall -pedantic -Dopenbsd -DIPv4 -Os -fpack-struct -DLWIP_DEBUG  
-I../../../../src/include -I../../../../ports/unix/include  
-I../../../../src/include/ipv4 -I../../../../src/include/ipv6 -I.  
-I../../../../apps/snmp_private_mib -c     ../../../../src/core/def.c
145 cc -g -Wall -pedantic -Dopenbsd -DIPv4 -Os -fpack-struct -DLWIP_DEBUG  
-I../../../../src/include -I../../../../ports/unix/include  
-I../../../../src/include/ipv4 -I../../../../src/include/ipv6 -I.  
-I../../../../apps/snmp_private_mib -c     ../../../../src/core/ipv4/icmp.c
146 cc -g -Wall -pedantic -Dopenbsd -DIPv4 -Os -fpack-struct -DLWIP_DEBUG  
-I../../../../src/include -I../../../../ports/unix/include  
-I../../../../src/include/ipv4 -I../../../../src/include/ipv6 -I.  
-I../../../../apps/snmp_private_mib -c

Wojciech

> Wojciech A. Koszek wrote:
> > That was my first guess. But GCC complained about it, since in
> > src/core/timers.c
> > has this:
> >
> > 432 #if PBUF_POOL_FREE_OOSEQ
> > 433       PBUF_CHECK_FREE_OOSEQ();
> > 434 #endif /* PBUF_POOL_FREE_OOSEQ */
> >
> > This calls pbuf_free_ooseq(). If you get rid of this from this file
> > (somehow),
> > we'll be able to make pbuf_free_ooseq() static or remove it at all.
> >
> > This is the only place that calls PBUF_CHECK_FREE_OOSEQ.
>
>
> _______________________________________________
> lwip-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/lwip-devel


--
Wojciech A. Koszek
address@hidden
http://FreeBSD.czest.pl/~wkoszek/