[lwip-devel] [bug #34581] missing parentheses in udplite sockets code

[Amir Shalem]

URL:
  <http://savannah.nongnu.org/bugs/?34581>

                 Summary: missing parentheses in udplite sockets code
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: amirshalem
            Submitted on: Mon 17 Oct 2011 11:32:11 PM GMT
                Category: sockets
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:

gcc recommends suggest parentheses around ‘&&’ within ‘||’:

-      if ((*(int*)optval != 0) && ((*(int*)optval < 8)) || (*(int*)optval >
0xffff)) {
+      if ((*(int*)optval != 0) && (((*(int*)optval < 8)) || (*(int*)optval >
0xffff))) {

add patch to fix those bugs

thanks,
amir shalem




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?34581>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/