lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #34638] Dead code in tcp_receive - pcb->dupacks


From: Bill Auerbach
Subject: [lwip-devel] [bug #34638] Dead code in tcp_receive - pcb->dupacks
Date: Mon, 24 Oct 2011 22:07:29 +0000
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

Follow-up Comment #1, bug #34638 (project lwip):

The intent I think was to prevent dupacks from overflowing (wrapping).  But it
can't work without a cast:

if ((u8_t) (pcb->dupacks + 1) > pcb->dupacks)
  ++pcb->dupacks; 

I seem to remember this coming up in the past.  Yeah:

https://lists.nongnu.org/archive/html/lwip-users/2010-02/msg00231.html


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?34638>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]