[lwip-devel] [bug #35574] Lockup in httpd (the older non-SSI/CGI httpd)

[Simon Goldschmidt]

Update of bug #35574 (project lwip):

                  Status:               Confirmed => Fixed                  
             Assigned to:                    None => goldsimon              
             Open/Closed:                    Open => Closed                 
         Planned Release:                         => 1.4.1                  

    _______________________________________________________

Follow-up Comment #8:

> http_send_data_nonssi is structured the same way as it is in 
> mine which I guess a 1.3.2 version of httpd for httpserver_raw.

> Looks like tcp_write can be called (whatever the circumstance) 
> with len == 0 after the if/else. For me hs->len was 0 and
> hs->file was NULL.

http_send_data_nonssi() should only be called with hs->file==NULL and len==0
any more, since this is checked in http_send() before:

  if (hs->left == 0) {
    if (!http_check_eof(pcb, hs)) {
      return 0;
    }
  }

.. where http_check_eof() returns 0 if hs->file == NULL.
Nonetheless, I added a check for len==0 in http_write() to prevent triggering
the error.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?35574>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/