[lwip-devel] [bug #35874] reserved identifier violation

[Markus Elfring]

URL:
  <http://savannah.nongnu.org/bugs/?35874>

                 Summary: reserved identifier violation
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: elfring
            Submitted on: Sa 17 Mär 2012 15:40:19 CET
                Category: None
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: 1.4.0

    _______________________________________________________

Details:

I suggest to try the search pattern "\<_(?:(?:_(.*))|([A-Z]+))" on source
files.
Some places will be found where names begin with two underscores or an
underscore and an uppercase letter.

Examples:
* __LWIP_API_H__
<http://git.savannah.gnu.org/cgit/lwip.git/tree/src/include/lwip/api.h?id=a2aa43a426bb01f926f7935299c19fe00030ab4e#n32>
* __LWIP_IP6_H__
<http://git.savannah.gnu.org/cgit/lwip.git/tree/src/include/ipv6/lwip/ip6.h?id=ccd7dbe0e4aa698cb96f85a88dab149066420bb3#n41>

This usage does not fit
<https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29>
to the expected naming conventions of the C/C++ language standard.
I recommend to adjust your selection for unique names.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?35874>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/