[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-devel] BSD/Linux compatibility
|
From: |
James G. Smith |
|
Subject: |
Re: [lwip-devel] BSD/Linux compatibility |
|
Date: |
Mon, 02 Jul 2012 13:16:56 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.16 |
On 07/02/2012 11:04 AM, Mason wrote:
> James G. Smith wrote:
>> #define inet_ntop(__af,__src,__dst,__size) \
>> (((__af) == AF_INET6) ? ip6addr_ntoa_r((__src),(__dst),(__size)) :
>> ipaddr_ntoa_r((__src),(__dst),(__size)))
>
> Prefixing parameter names with underscores makes baby Jesus cry.
> What kind of name collision are you trying to avoid?
Not me. Honest :-)
I am happy with using parenthesis to protect macro parameters from
pre-processor malarky.
It is a convention used in bits of the target source that I am working
with, so had just "copied" that form when tinkering with lwIP. I will
gladly remove the underscores before I submit a patch.
-- Jamie