Re: [lwip-devel] ppp-new testing

[Sylvain Rochet]

Hi Ivan,


On Thu, Aug 16, 2012 at 02:18:09PM -0600, Ivan Delamer wrote:
> I'm testing the ppp-new branch, just wanted to report that I got it
> working (I had to increase the stack size for the TCP/IP thread, that was
> the cause of the previous crash experience).

Yeah, happy to hear that :-)


> A couple things I noticed:
> 
> - I had to add an include of <string.h> in ppp_impl.h

Added, this is hitless.


> - In magic.c, I moved the include of lwip_md5.h or md5.h into the #if
> PPP_MD5_RANDM block

Good catch, fixed.


> - I had to add "ppp.h" to memp.c (it seems to get included if pppoe is
> enabled, but I use pppos)

Yeah, I knew about that, this is now fixed with the great include move 
which allowed me to add include/netif/ppp/ppp.h without forcing the user 
to add netif/ppp/ to its include path.

Maybe we should include PPP headers only if PPP is compiled so that 
lwIP users can remove ppp/ from their project if they want to ?


Thanks !

Sylvain

signature.asc
Description: Digital signature