lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #7883] Unit test fixes


From: Erik Ekman
Subject: [lwip-devel] [patch #7883] Unit test fixes
Date: Sun, 04 Nov 2012 10:52:08 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.89 Safari/537.1

URL:
  <http://savannah.nongnu.org/patch/?7883>

                 Summary: Unit test fixes
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: yarrick
            Submitted on: Sun 04 Nov 2012 10:52:06 AM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

I have fixed the test cases so they run and work on unix. The test_pbuf file
was missing and its test expected to abort. A dhcp test had const arrays which
were changed - this caused a segfault. I have also modified the test macros to
include the test name in any errors.

Please pull the changes from the 'toupstream' branches at:
git://github.com/yarrick/lwip.git
git://github.com/yarrick/lwip-contrib.git


Changes in lwip:

commit 8c933cb55ee4f56b9b08114e4c495c7fa036bca5
Author: Erik Ekman <address@hidden>
Date:   Wed Sep 5 20:09:09 2012 +0200

    Expect SIGABRT on pbuf copy test

    The test_pbuf_copy_zero_pbuf test is expected to fail the assert check
and
    abort. Configure check to expect this signal to avoid failing the test.

 test/unit/core/test_pbuf.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

commit 008a69ef5f98cc5890079bc34ec19149013304f9
Author: Erik Ekman <address@hidden>
Date:   Sun Nov 4 11:28:22 2012 +0100

    Minor fixes to dhcp relay test

 test/unit/dhcp/test_dhcp.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

commit 69cbfbf979dfae9bfcb8dcace7a8229df4fdfc45
Author: Erik Ekman <address@hidden>
Date:   Fri Aug 31 18:45:12 2012 +0200

    Use macro to store correct testcase name

    Since check uses macros to get the testcase name, and the tests are added
from an array, the error looks like this:
    ../../../../lwip/test/unit/core/test_pbuf.c:49:E:Core:tests[i]:0: (after
this point) Received signal 6 (Aborted)
    (Note the tests[i] part)

    This patch creates a new macro used when listing test functions in the
array, which stores the name earlier.
    Then the test_add macro is modified to use the correct test name. New
error:
   
../../../../lwip/test/unit/core/test_pbuf.c:49:E:PBUF:test_pbuf_copy_zero_pbuf:0:
(after this point) Received signal 6 (Aborted)

    This makes it easier to find the name of the failing test function.

 test/unit/core/test_mem.c      |  6 +++---
 test/unit/core/test_pbuf.c     |  6 +++---
 test/unit/dhcp/test_dhcp.c     | 12 +++++------
 test/unit/etharp/test_etharp.c |  6 +++---
 test/unit/lwip_check.h         | 18 +++++++++++++----
 test/unit/tcp/test_tcp.c       | 18 ++++++++---------
 test/unit/tcp/test_tcp_oos.c   | 46
+++++++++++++++++++++---------------------
 test/unit/udp/test_udp.c       |  6 +++---
 8 files changed, 64 insertions(+), 54 deletions(-)

commit 071a2402729ffcbb11986076b940e91557fa5c61
Author: Erik Ekman <address@hidden>
Date:   Thu Aug 30 21:57:28 2012 +0200

    Don't mark arrays as const since they are modified by the test

 test/unit/dhcp/test_dhcp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


Changes in lwip-contrib:


commit 9c7141db139d2e1c554bc645c14ba51787148690
Author: Erik Ekman <address@hidden>
Date:   Thu Aug 30 21:54:07 2012 +0200

    Include core/test_pbuf.c file in build

 ports/unix/check/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7883>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]