[lwip-devel] [bug #39226] Validity of netif IPv6 address is not always checked

[Valery Ushakov]

URL:
  <http://savannah.nongnu.org/bugs/?39226>

                 Summary: Validity of netif IPv6 address is not always checked
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: uwe
            Submitted on: Tue 11 Jun 2013 12:27:52 AM GMT
                Category: IPv6
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

There are a few places where validity of netif IPv6 address is not checked,
usually in a code like this:


for (i = 0; i < LWIP_IPV6_NUM_ADDRESSES; i++) {
  if (ip6_addr_cmp(netif_ip6_addr(netif, i), ...)) {
    ...


Attached patch fixes the few places I found via source code inspection, but
while checking this I found some places that *do* check address validity,
*but* do it with ip6_addr_isvalid().  Appears correct at the first glance, but
tentative addresses are not considered ip6_addr_isvalid(), and I think at
least in some of those places the tentative addresses are intended to be ok.

Someone with a clue should review that.

My patch goes for conservative !ip6_addr_isinvalid() - just to protect from
checking garbage memory.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 11 Jun 2013 12:27:52 AM GMT  Name: valid-ip6-addr.diff  Size: 3kB  
By: uwe

<http://savannah.nongnu.org/bugs/download.php?file_id=28289>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?39226>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/