[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #7885] modification of api modules to support FreeRT
|
From: |
Artem Pisarenko |
|
Subject: |
[lwip-devel] [patch #7885] modification of api modules to support FreeRTOS-MPU (NO_SYS = 0) |
|
Date: |
Fri, 21 Feb 2014 05:53:30 +0000 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36 |
Follow-up Comment #7, patch #7885 (project lwip):
I'm glad to see my contribution accepted.
I compared what you modified and found an error in netconn_gethostbyname()
function:
if (addr == NULL) {
addr = IP_ADDR_ANY;
}
Firstly, condition will never be true because of LWIP_ERROR() check above.
Secondly, if it even would be, 'addr' will point to constant variable,
followed with
*addr = msg->addr;
Also I found my own oversight of 'name' argument. Only pointer passed via
'msg', but it may point to stack-located string. So whole string must be
passed.
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?7885>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/