[lwip-devel] [patch #8446] LWIP IP Re-assembly timer optimization

[Simon Goldschmidt]

Follow-up Comment #1, patch #8446 (project lwip):

Your patch is tempting, but it breaks dependencies: as it is now, lwIP core
files should not depend on the timer implementation. In other words, everyone
is free to implement a different timer implementation as long as the timers
are called as needed.

You can see a way to implement what you want in tcp.c/timer.c: TCP calls
tcp_timer_needed() when a timer is needed and timer.c then starts the timer if
it is not alreay running. This way, developers are free to implement a more
efficient way of timer handling in their port and have the TCP timer only
running when needed.

Would you mind rewriting your patch to fit this?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?8446>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.nongnu.org/