[lwip-devel] [bug #44069] udp_sendto and similar don't accept const destination addresses

[chrysn]

Follow-up Comment #2, bug #44069 (project lwip):

i've now prepared a patch on master, which was created in a slightly more
systematic way (by going through all header files that mention ip_addr_t).

it has shown that the api change not only affects the ip_send functions, but
also the udp and raw recv functions; still, i think it's the right thing to
do.

i've just discovered how to run the unit tests, and not yet added the const
qualifiers to the unit tests. the tests don't cover the api header, dhcp and
some other parts of lwip that are not used in my projects. is there a kind of
reference program that builds larger parts of lwip which i can use for
testing? (not that i'd expect anything else but compiler warnings/errors, but
still...) with such a reference, i could go through the files i haven't
touched yet, and files that affect ip6_addr_t.

i'm unsure about the inet_ntoa macros. they include a cast, that would
previously have stripped a const qualifier. as that is not required any more
because ipaddr_ntoa now has a const argument anyway, is there any reason for
the cast to be still present?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?44069>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/