Re: [lwip-devel] API change: restructuring ipv4/ipv6 integration (task #12722)

[Sylvain Rochet]

Hello Simon,


On Thu, Apr 09, 2015 at 10:19:53PM +0200, address@hidden wrote:
> Hi all,
> 
> for those not reading lwip-users:
> 
> goldsimon wrote:
> > I just wanted to warn you I'm going to push a rather big change
> > regarding ipv4/ipv6 integration where the old 'ip_addr_t' will be
> > renamed to ip4_addr_t and ip_addr_t changed to replace ipX_addr_t,
> > including a version information. This ensures ipv4 and ipv6 addresses
> > are handled equal (more or less).
> >
> > This results in an API change, which should hopefully not be noticed by
> > ipv4-only users (LWIP_IPV6==0). In case it does change anything, please
> > reply here!
> >
> > This is in preparation for the 1.5.0 release, but I expect more changes
> > in this area after possibly discussing this further on lwip-devel, so
> > the API might change again in the next weeks or so. So unless you really
> > want to follow development, I suggest to not pull master tip unless we
> > have sorted this out.
> 
> This mainly means that the tcp/udp/raw API uses dual-version IP
> addresses everywhere and most of the IPv6-specific functions/defines
> are removed.

Woah, that's such a great rework.


> I'm just pushing this now to get forward on 1.5.0, but please feel
> free to share your critics here!
> 
> I hope that there are no compiler errors left, but given the amount
> of possible define-combinations and function-like-defines I might
> not all use, chances are I missed some, so please share them here if
> you find any.

Unfortunately, we are now hitting GCC bug #53119 [1][2][3].

lwip/src/core/ipv4/ip4_addr.c:53:3: warning: missing braces around initializer 
[-Wmissing-braces]
   }, IPADDR_TYPE_V4
   ^
lwip/src/core/ipv4/ip4_addr.c:53:3: warning: (near initialization for 
‘ip_addr_any.addr.ip4’) [-Wmissing-braces]
lwip/src/core/ipv4/ip4_addr.c:62:3: warning: missing braces around initializer 
[-Wmissing-braces]
   }, IPADDR_TYPE_V4
   ^
lwip/src/core/ipv6/ip6_addr.c:53:3: warning: missing braces around initializer 
[-Wmissing-braces]
   { 0ul }, IPADDR_TYPE_V6
   ^

Adding an extra brace level shut up the compiler warning, does it still 
work for all compilers ?

Sylvain


[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119
[2] 
http://stackoverflow.com/questions/11551986/gcc-missing-braces-around-initializer
[3] 
http://stackoverflow.com/questions/13746033/how-to-repair-warning-missing-braces-around-initializer

signature.asc
Description: Digital signature