[lwip-devel] [bug #45159] Is this part of do_writemore() in api_msg.c correct?

[Roberto Barbieri Carrera]

URL:
  <http://savannah.nongnu.org/bugs/?45159>

                 Summary: Is this part of do_writemore() in api_msg.c correct?
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: sebulain
            Submitted on: Thu 21 May 2015 09:23:53 AM GMT
                Category: TCP
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: 1.4.1

    _______________________________________________________

Details:

Hello

Trying to solve some problems that I'm having with TCP retransmissions (still
not clear enough to report), I run into the following piece of code.

File api_msg.c, function do_writemore(), line 1274:
      if (dontblock && (len < conn->current_msg->msg.w.len)) {

I have the feeling this should be:
      if (dontblock && ((conn->write_offset + len) <
conn->current_msg->msg.w.len)) {

I don't think this is the source of my problems, but I wanted to report this
so that the people that know more about the code can check it.

Thanks for lwIP, and kind regards,
Roberto Barbieri Carrera
Archwave AG





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?45159>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/