[lwip-devel] [bug #45708] LWIP_ASSERT in api_msg.c, function err_tcp, seems wrong.

[Paul Szego]

URL:
  <http://savannah.nongnu.org/bugs/?45708>

                 Summary: LWIP_ASSERT in api_msg.c, function err_tcp, seems
wrong.
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: pszego
            Submitted on: Thu 06 Aug 2015 05:17:12 PM GMT
                Category: TCP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

The LWIP_ASSERT at line 418, in function err_tcp() doesn't seem correct:

      LWIP_ASSERT("inavlid op_completed_sem", op_completed_sem !=
SYS_SEM_NULL);

The declaration of op_completed_sem:

    sys_sem_t* op_completed_sem

so it's a *pointer* to a sys_sem_t, whereas SYS_SEM_NULL is just a plain
sys_sem_t. Perhaps replace that assert with this:

      LWIP_ASSERT("inavlid op_completed_sem", *op_completed_sem !=
SYS_SEM_NULL);





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?45708>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/