[lwip-devel] [bug #46594] Useless condition judegement

[Joel Cunningham]

Follow-up Comment #2, bug #46594 (project lwip):

Here's the entire block of code.  Comment above indicates it's checking for
loop_cnt_current overflowing and wrapping (which would be a smaller value)

#if LWIP_LOOPBACK_MAX_PBUFS
  clen = pbuf_clen(r);
  /* check for overflow or too many pbuf on queue */
  if(((netif->loop_cnt_current + clen) < netif->loop_cnt_current) ||
     ((netif->loop_cnt_current + clen) > LWIP_LOOPBACK_MAX_PBUFS)) {
    pbuf_free(r);
    LINK_STATS_INC(link.memerr);
    LINK_STATS_INC(link.drop);
    MIB2_STATS_NETIF_INC(stats_if, ifoutdiscards);
    return ERR_MEM;
  }

This seems like a valid check to me

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?46594>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/