Re: [lwip-devel] Behaviour of netifapi_netif_set_addr()

[Dirk Ziegelmeier]

Noone seems to have objections - I think your proposal with the NULL pointers is OK then, I like it. (I'd also like to forbit NULL pointers as IP address parameters globally, I added the NULL->IP_ADDR_ANY substituions so we don't need to check for NULL pointers everywhere in the code in the future)

Ciao
Dirk

--
Dirk Ziegelmeier * address@hidden * http://www.ziegelmeier.net

On Tue, Apr 5, 2016 at 4:16 PM, Dirk Ziegelmeier <address@hidden> wrote:

AFAIK NULL was a global alias to IPADDR_ANY before, so it was not undocumented. But how many people actually called this function with NULL/ANY address? Does somebody on the list have an idea?

Ciao
Dirk

--
Dirk Ziegelmeier * address@hidden * http://www.ziegelmeier.net

On Tue, Apr 5, 2016 at 4:13 PM, Freddie Chopin <address@hidden> wrote:

On wto, 2016-04-05 at 15:58 +0200, Dirk Ziegelmeier wrote:
> yes, I think it should be in netif_set_addr. But I'm unsure if this
> is a compatibility issue for some users. Maybe Simon has an opinion
> about it?

Yes, that can be an issue, but I've read on the list that the next
release of lwIP will be 2.0, so I'm guessing the API is already changed
somewhere.

It is worth noting, that the comment for netif_set_addr() (and
netif_set_ipaddr() and others) doesn't mention how NULL is treated, so
actually anyone using NULL there was depending on undocumented feature
(;

Regards,
FCh

_______________________________________________
lwip-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/lwip-devel