[lwip-devel] [patch #9211] mqtt: Check Will Flag rather than will_topic_len for appending will topic and message

[Dirk Ziegelmeier]

Update of patch #9211 (project lwip):

                  Status:                    None => Wont Do                
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #3:

OK, you are right there.

But then your patch is just a change in coding style. Erik Andersen wrote
"will_topic_len > 0" which is not slower or less readable than "flags &
MQTT_CONNECT_FLAG_WILL". I don't want to apply patches that just change one
person's coding style to the one of another person. A patch should be a _real_
improvement in readability (less #ifdefs, simplify complex code etc.) or fix
bugs.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9211>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/