[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9211] mqtt: Check Will Flag rather than will_topic_

From: Dirk Ziegelmeier
Subject: [lwip-devel] [patch #9211] mqtt: Check Will Flag rather than will_topic_len for appending will topic and message
Date: Sat, 7 Jan 2017 19:34:06 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Update of patch #9211 (project lwip):

                  Status:                    None => Wont Do                
             Open/Closed:                    Open => Closed                 


Follow-up Comment #3:

OK, you are right there.

But then your patch is just a change in coding style. Erik Andersen wrote
"will_topic_len > 0" which is not slower or less readable than "flags &
MQTT_CONNECT_FLAG_WILL". I don't want to apply patches that just change one
person's coding style to the one of another person. A patch should be a _real_
improvement in readability (less #ifdefs, simplify complex code etc.) or fix


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]