[lwip-devel] [bug #50040] pbuf_alloc(..., 65534, PBUF_RAM) succedes

[David van Moolenbroek]

Follow-up Comment #2, bug #50040 (project lwip):

For clarity I should actually add a bit more of my reasoning as to why I think
just detecting the overflow is insufficient: there are currently cases where
lwIP itself will attempt to allocate buffers that large, e.g. the multicast
duplication case in udp_input(). Failing the allocation in the overflow case
would result in actual loss of functionality there. At the same time,
everything *should* go well there if the allocation is not truncated -
although obviously I have not been able to test that yet.

[Off-topic: that udp case does worry me: even if allocation doesn't get
truncated, it will hit the assertion I mentioned, but lwIP doesn't seem to
have a clear model for "use PBUF_POOL for allocation if we are using pools, or
PBUF_RAM otherwise" so I am not sure what should be done there. There are
probably other cases like that, and this does worry me quite a bit..]

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?50040>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/