[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9272] arp/ndp: allow overriding the decision to cop
|
From: |
Simon Goldschmidt |
|
Subject: |
[lwip-devel] [patch #9272] arp/ndp: allow overriding the decision to copy pbufs |
|
Date: |
Mon, 27 Feb 2017 15:48:50 -0500 (EST) |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 |
Follow-up Comment #1, patch #9272 (project lwip):
Hm, to me the correct thing to do would be to only copy PBUF_REF.
Back in 2007, the result of discussion in bug #11400 seemed to be that we need
to copy everything but PBUF_ROM because an application was allowed to reuse a
pbuf after passing it to the stack.
I'm not so sure about that any more: I think it would be best to say an
application *must not* use a pbuf passed to a TX function *if that function
returned ERR_OK*. That would save us a lot of problems here.
I'm OK with your patch though as it just defers the decision and actually
improves the documentation (i.e. "why does everything but PBUF_ROM have to be
copied").
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?9272>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/