[lwip-devel] [bug #50614] TCP: new ACK processing, unsent queue check and pcb->sndbuf update in wrong spot

[Joel Cunningham]

Follow-up Comment #4, bug #50614 (project lwip):

I agree that ACKs <= pcb->lastack would no longer invoke the check of
pcb->unsent.  Checking pcb->unsent for that case should NOT be unnecessary
because we would have already performed the check when lastack was updated. 
The only way a segment could remain is if the ACK didn't fully ack the
segment, at which-point an ACK greater than lastack would be required to ACK
it.  Further, if a check was really needed in that case, it should also be
performed on unacked as well (which hasn't been the case)

Good point on combining the two loops, they do almost identical logic on the
queues.  For right now, I'd like to minimize the change and commit this patch.
 Another patch can generalize the logic to operate on both loops

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?50614>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/