|Subject:||Re: [lwip-devel] sockets.c: Possible to return from lwip_select without decrementing sockets used|
|Date:||Tue, 18 Apr 2017 20:49:58 +0200|
|User-agent:||Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0|
Thanks for the patches, I've just pushed them. However, we prefer to have patches sent to our patch tracker at https://savannah.nongnu.org/patch/?group=lwip since they easily get overlooke here in times where there are many mails and too little man power to catch up...
Hi all, Just updated to 0952e618, and found an issue in lwip_select: It looks like we return without decrementing appropriate fd_used when lwip_selscan returns < 0. See first patch. Also included is a super bonus patch for sock_inc_used(), which currently might fail to notice an overflow. The patch ensures that the inc and test are done atomically. Cheers, Tim
|[Prev in Thread]||Current Thread||[Next in Thread]|