[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [task #14247] socket API: implement recvmsg msg_control sup
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [task #14247] socket API: implement recvmsg msg_control support |
Date: |
Tue, 18 Apr 2017 16:00:49 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36 |
Follow-up Comment #12, task #14247 (project lwip):
Looks good. I can't comment on the corectness of the socket.h/.c additions
though (CMSG...) without reading into the specs. But I guess that doesn't
really matter. If it should be wrong, we can always fix it later.
I have two questions/comments though:
1) A thing that looks strange is accessing the netconn's pcb without locking.
Even if it's only a read access, chances are that the pcb already got
deallocated. If not now, this might happen in the future. Isn't it enough to
check the flag in the netbuf in this case?
2) Shouldn't the new feature work with LWIP_NETBUF_RECVINFO==1, too?
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/task/?14247>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/13
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/13
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/15
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support,
Simon Goldschmidt <=
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/19
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Simon Goldschmidt, 2017/04/19
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/19
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Simon Goldschmidt, 2017/04/19
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/19
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/25
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Simon Goldschmidt, 2017/04/25
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/25
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Simon Goldschmidt, 2017/04/25
- [lwip-devel] [task #14247] socket API: implement recvmsg msg_control support, Joel Cunningham, 2017/04/25