[lwip-devel] [task #14128] Appropriate byte counting/stretch ACK support

[Joel Cunningham]

Follow-up Comment #23, task #14128 (project lwip):

 > Looks good, too. The downside is that this is another option noone will
ever change. Since the default is 'enabled', maybe it's better to just use it
and dump the old behaviour? All the #if code looks so ugly... 

I'm fine with removing the old behavior, which would mean we don't need an
LWIP_TCB_ABC option. I suppose I was just being conservative about the changes
:)

> Oh, and regarding comment #16: how much sense does it make to configure the
limit if we only allow integers? The only possible settings seem to be '1' or
'2', reading the RFC.

Someone being more experimental could set the LIMIT to a higher value than 2
to support stretch ACKs spanning more than 2 segments, even though that's
against the RFC's guidance.  Maybe having this as an option is
over-thinking/engineering it.  We could just use 2 for now and then revisit it
as an option if there is desire/feedback from users.  What do you think?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?14128>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/