[lwip-devel] [patch #9384] Partial SACK (RFC 2018) support

[Simon Goldschmidt]

Follow-up Comment #14, patch #9384 (project lwip):

This response comes kind of late but...
> To not violate MSS while adding SACKs to full packets would
> mean not sending all of that packet's payload.
> It feels like a nightmare from segment management perspective.

Given that and reading the RFC, I feel sending the SACKs in empty ACKs could
be good enough. The RFC clearly separates receiver and transmitter...

However, that would also mean we would have to send empty ACKs when SACKs are
to be send. We currently avoid this and piggy-back the ACK on data if there's
data to be sent (by letting 'tcp_ack()' set "pcb->flags |= TF_ACK_NOW") - that
would have to be changed.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9384>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/