Re: [lwip-devel] Sockets: select_waiting overflow

[address@hidden]

Joan Lledó wrote:
> I'm having an overflow in my select_waiting due to a bug, and the
> assertion "sock->select_waiting > 0" is failing and aborting the
> stack.
>
> Would it not be better to use LWIP_ERROR instead of LWIP_ASSERT?, to
> allow the user to return gracefully with a proper errno. The current
> assertion could be used in a DoS attack to abort the stack from a
> client.

Well, ehrm... a DoS tricking you into creating more than 255 threads? I 
can't really imagine that to happen on a µC that lwIP is targeting, but 
just in case, yes: this could be fixed better. Could you file a bug so 
this doesn't get forgotten?

Thanks,
Simon