[lwip-devel] [bug #51507] Keep uses of SYS_ARCH_PROTECT/UNPROTECT in alloc_socket nested.

[Coder]

URL:
  <http://savannah.nongnu.org/bugs/?51507>

                 Summary: Keep uses of SYS_ARCH_PROTECT/UNPROTECT in
alloc_socket nested.
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: ourairquality
            Submitted on: Wed 19 Jul 2017 01:26:03 PM UTC
                Category: sockets/netconn
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

When the LWIP_NETCONN_FULLDUPLEX feature is enabled the loop was calling
SYS_ARCH_PROTECT at the start and it appears that it was possible to
'continue' and repeat that loop with going via SYS_ARCH_UNPROTECT. So there
could be multiple calls to SYS_ARCH_PROTECT without matching calls to
SYS_ARCH_UNPROTECT.

The patch simply hoists this out of the loop, but if that were not considered
fine enough then an alternative would be to call SYS_ARCH_UNPROTECT before
'continue'.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 19 Jul 2017 01:26:03 PM UTC  Name:
0001-Keep-uses-SYS_ARCH_PROTECT-UNPROTECT-in-alloc_socket.patch  Size: 1KiB  
By: ourairquality

<http://savannah.nongnu.org/bugs/download.php?file_id=41243>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?51507>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/