[lwip-devel] [bug #51593] Fix swapped src/dst params with ip4_route_src

[Joel Cunningham]

URL:
  <http://savannah.nongnu.org/bugs/?51593>

                 Summary: Fix swapped src/dst params with ip4_route_src
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: jcunningham
            Submitted on: Thu 27 Jul 2017 04:00:40 PM UTC
                Category: IPv4
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head

    _______________________________________________________

Details:

I found some occurrences of ip4_route_src() with the src, dst parameters in
the wrong order.  The UDP case was found through testing and the ICMP issue
through code analysis of ip4_route_src

This appears to be a typo to me, most likely due to confusion with
ip_route(src, dst) and ip4_route_src(dst, src).

More details about UDP issue:

LWIP_IPV4_SRC_ROUTING is 0.  The UDP application socket was bound to
INADDR_ANY with IP_MULTICAST_IF set. Transmits would result in calling
ip4_route(dst) where dst was pcb->local_addr (which was INADDR_ANY) instead of
pcb->mcast_ip4. This resulted in a routing failure




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 27 Jul 2017 04:00:40 PM UTC  Name:
0001-ip4-fix-swapped-src-dst-params-with-ip4_route_src.patch  Size: 2KiB   By:
jcunningham

<http://savannah.nongnu.org/bugs/download.php?file_id=41362>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?51593>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/