[lwip-devel] [task #14597] cleanup pbuf_header usages

[Simon Goldschmidt]

URL:
  <http://savannah.nongnu.org/task/?14597>

                 Summary: cleanup pbuf_header usages
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Fri 04 Aug 2017 11:19:36 AM UTC
                Category: pbufs
         Should Start On: Fri 04 Aug 2017 12:00:00 AM UTC
   Should be Finished on: Fri 04 Aug 2017 12:00:00 AM UTC
                Priority: 5 - Normal
                  Status: In Progress
                 Privacy: Public
        Percent Complete: 30%
             Assigned to: goldsimon
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
                  Effort: 0.00

    _______________________________________________________

Details:

I've just split pbuf_header(s16_t) into pbuf_add_header(size_t) and
pbuf_remove_header(size_t)

The new functions both take size_t as increment/decrement argument instead of
s16_t (which needed to be range-checked before conversion everywhere) - in
most places, the direction (increment or decrement) is known anyway, so no
need to encode it in a sign bit.

Next step is to udpate all stack-internal usages of pbuf_header (where
appropriate - i.e. where the direction is known and the increment value is not
already an s16_t).

pbuf_header() will of course remain working for compatibility.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?14597>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/