[lwip-devel] Question about 90873d6

[Joel Cunningham]

In change 90873d6, the following was part of the patchset:

-              } else if (pcb->dupacks == 3) {
-                /* Do fast retransmit */
+              } else if (pcb->dupacks >= 3) {
+               /* Do fast retransmit (checked via TF_INFR, not via dupacks 
count) */

I think the >3 case can never get there because the if preceding checks that 
dupacks is > 3:

if (pcb->dupacks > 3) {
  /* Inflate the congestion window, but not if it means that
      the value overflows. */
    if ((tcpwnd_size_t)(pcb->cwnd + pcb->mss) > pcb->cwnd) {
      pcb->cwnd = (tcpwnd_size_t)(pcb->cwnd + pcb->mss);
    }
} else if (pcb->dupacks >=3) {
…

Should the original == 3 be restored?

Joel