[lwip-devel] Unsafe use of netif_get_by_index() in lwip_socket_drop

lwip-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] Unsafe use of netif_get_by_index() in lwip_socket_drop_regi

From:	Joel Cunningham
Subject:	[lwip-devel] Unsafe use of netif_get_by_index() in lwip_socket_drop_registered_mld6_memberships
Date:	Wed, 16 Aug 2017 11:10:41 -0500

Dirk,

I just did a quick review of e58e398267b0a2eedfcd5c695da9e5929d6173e1 and 
noticed in lwip_socket_drop_registered_mld6_memberships we are calling 
netif_get_by_index() outside of the LwIP context (TCP/IP thread or CORE_LOCK).  
This isn’t safe because netif_get_by_index() iterates the netif_list, which may 
be changing as someone calls netif_add/remove

Joel

[Prev in Thread]

Current Thread

[Next in Thread]

[lwip-devel] Unsafe use of netif_get_by_index() in lwip_socket_drop_registered_mld6_memberships, Joel Cunningham <=
- Re: [lwip-devel] Unsafe use of netif_get_by_index() in lwip_socket_drop_registered_mld6_memberships, Dirk Ziegelmeier, 2017/08/16

Prev by Date: [lwip-devel] [bug #51765] pcb->dupacks > 3 logic added in 90873d6 not possible
Next by Date: Re: [lwip-devel] Unsafe use of netif_get_by_index() in lwip_socket_drop_registered_mld6_memberships
Previous by thread: [lwip-devel] [bug #51765] pcb->dupacks > 3 logic added in 90873d6 not possible
Next by thread: Re: [lwip-devel] Unsafe use of netif_get_by_index() in lwip_socket_drop_registered_mld6_memberships
Index(es):
- Date
- Thread