[lwip-devel] [bug #50837] TCP: zero window probe doesn't timeout

[Joel Cunningham]

Follow-up Comment #50, bug #50837 (project lwip):

> tcp_in.c not resetting the persist timer any more looks a little odd. But
since we always call tcp_output() for every received ACK, it should be good I
guess. 

Yes, that's the core concept change, only perform maintenance on the timer in
tcp_output(), which determines whether we can really send a segment or not :)

> Maybe I'd move tcp_split_unsent_seg() and make it static...

So tcp_split_unsent_seg() is called from tcp.c and I placed the implementation
in tcp_output.c since it was an "output" specific function.  Would you prefer
it in tcp.c?




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?50837>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/