[lwip-devel] [patch #9450] New sockets function: lwip_poll

[Joel Cunningham]

Follow-up Comment #5, patch #9450 (project lwip):

I had a chance to review the poll changes and spotted a couple minor things to
clean up:

1) lwip_poll() will data abort inside of lwip_pollscan() if fds is NULL and
nfds > 0.  We can handle this by checking for this case in lwip_poll() and
returning -1 with errno = EINVAL.  Also might be good to error for fds != NULL
and nfds == 0.

2) lwip_poll_should_wake() should be using has_recvevent, has_sendevent, and
has_errevent available in select_check_waiters() rather using the sock
pointer.  The has_* copies are meant to store the events after we have called
SYS_ARCH_UNPROTECT and left the critical section

I'll post a patch in the next couple of days




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9450>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/