Re: [lwip-devel] What is xchar() macro?

[Dirk Ziegelmeier]

I had to move the functions to lwIP's porting layer, they are used in ip4_addr.c, too :-)

​Side-effect: Code duplication cleanup...​

Ciao
Dirk

On Thu, Nov 2, 2017 at 2:46 PM, Joel Cunningham <address@hidden> wrote:

On 11/02/2017 04:08 AM, Dirk Ziegelmeier wrote:

The patch is OK for me.

For the other functions: To be correct, they should go to cc.h and be documented in the porting layer. I can do that if desired. But the drawback would be that ctype.h would

​is globally included in many headers of lwIP (because cc.h needs to include it), and given the "complexity" of these functions I'd consider this overkill. It would only be OK to do so if they were used in several places.

​IMHO, the macro names should simply be prepended with lwip_ and be locally defined in the single file that uses them. Opinions, anyone?

I'm fine with them being local to ip6_addr.c for now and revisiting when other files need to use them!

Ciao
Dirk

On Thu, Nov 2, 2017 at 1:05 AM, Joel Cunningham <address@hidden> wrote:

On 11/01/2017 02:06 PM, address@hidden wrote:

Joel Cunningham wrote:

I think a simple fix would be moving the xchar macro out of that block
and we could guard with #ifndef xchar for whatever bizarre platform
provides it

Or move it out of the block and define it unconditionally with a lwip_ prefix.
Maybe even as a static function. I don't think there's too much to improve here by using a central definition if we can't find one now.

Attached patch implements the conversion to a static lwip_xchar()...and provides some documentation :)

Joel

Joel

_______________________________________________
lwip-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/lwip-devel