[lwip-devel] [patch #9504] Fix build warning for lwip_isdigit/isxdigit/islower/isspace

[Axel Lin]

URL:
  <http://savannah.nongnu.org/patch/?9504>

                 Summary: Fix build warning for
lwip_isdigit/isxdigit/islower/isspace
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: axellin
            Submitted on: Thu 30 Nov 2017 03:44:47 AM UTC
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

lwip_isdigit/isxdigit/islower/isspace takes int as argument, so
explicitly cast to int to silence below build warnings.

src/core/ipv4/ip4_addr.c: In function 'ip4addr_aton':
src/core/ipv4/ip4_addr.c:160:5: warning: array subscript has type 'char'
[-Wchar-subscripts]
     if (!lwip_isdigit(c)) {
     ^
src/core/ipv4/ip4_addr.c:175:7: warning: array subscript has type 'char'
[-Wchar-subscripts]
       if (lwip_isdigit(c)) {
       ^
src/core/ipv4/ip4_addr.c:178:7: warning: array subscript has type 'char'
[-Wchar-subscripts]
       } else if (base == 16 && lwip_isxdigit(c)) {
       ^
src/core/ipv4/ip4_addr.c:179:9: warning: array subscript has type 'char'
[-Wchar-subscripts]
         val = (val << 4) | (u32_t)(c + 10 - (lwip_islower(c) ? 'a' : 'A'));
         ^
src/core/ipv4/ip4_addr.c:204:3: warning: array subscript has type 'char'
[-Wchar-subscripts]
   if (c != '\0' && !lwip_isspace(c)) {
   ^




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 30 Nov 2017 03:44:47 AM UTC  Name:
0001-Fix-build-warning-for-lwip_isdigit-isxdigit-islower-.patch  Size: 2KiB  
By: axellin

<http://savannah.nongnu.org/patch/download.php?file_id=42527>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9504>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/