lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9523] MDNS responder should reply after a random ti


From: Erik Ekman
Subject: [lwip-devel] [patch #9523] MDNS responder should reply after a random timeout
Date: Fri, 22 Dec 2017 05:08:28 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36

Follow-up Comment #1, patch #9523 (project lwip):

Thanks for the patch.

The RFC only states that query messages containing more than one question
SHOULD be delayed a bit. Not MUST - and multiple questions, not answers.

This feels like quite a bit of duplication of code. I would prefer also
delaying the creation of the packet.
That would mean splitting mdns_outpacket into the parts the needed to know
what packet to generate, and the parts needed while generating the packet
(like fields: pbuf, questions, answers, additional, domain_offsets) into
separate structs.

This can then also be used for multi-packet known address suppression, by
clearing some reply bits if a match is received while waiting to send.

The code for sending a packet immediately or later would then only be the
decision of when to convert the struct with the reply bits to the one with the
pbuf.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?9523>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]