[lwip-devel] [bug #52763] mdns: move data off the stack and dynamically allocate data.

[Douglas]

Follow-up Comment #3, bug #52763 (project lwip):

Thank you for all the feedback, and an attempt has been made to address it
all.

> Maybe having just a goto in the LWIP_ERROR macro and freeing the domain and
return in a common block? 

Done, this now assumes that the LWIP_ERROR always includes the handler forms
otherwise it will give unreachable code warnings. I had not understood that
LWIP_ERROR should have done that and had defined it to be empty in non-debug
code, but perhaps that was just my mistake? Was the intention for the
LWIP_ERROR check to always be performed, but perhaps only verbose in debug
builds?

> Running realloc on each adding of a name to a domain seems like it will
fragment memory very quickly - or maybe many of the realloc calls will need to
do nothing if more memory than requested is given earlier.

There are trade offs, and stack allocation is fast and simple, but it is not
easy to grow a stack allocation and allocating the peak usage seems excessive
for a very limited system.

The use of realloc() has been removed for now, it uses mem_malloc() and
mem_free().


(file #42771)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-mdns-move-data-off-the-stack-and-dynamically-allocat.patch
Size:68 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?52763>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/