[lwip-devel] [bug #52770] mdns: move the announcements to a timer callback

[Douglas]

Follow-up Comment #7, bug #52770 (project lwip):

> So your starting to use core locking for a callback style application does
not really fit to lwIP the way it was.

Thank you that helps. So I'll remove the mdns thread safe entry points, and
make a note that the caller is expected to hold the core lock.

> Would it be too hard to write your application to call LOCK_TCPIP_CORE()
before calling into mdns? 

Yes, that seems workable.

Could assertions be added at some of these entry points, that require the core
lock held, to check that it really is? Might this be implemented within lwip
by a simple flag set by the LOCK_TCPIP_CORE() macro and cleared when
unlocked?

> Core locking is already the default and message passing should be removed in
one of the next releases, so you're OK with only implementing core locking
code. 

Will that mean the netifapi entry points are removed too? I just started to
use these, but should the caller be using LOCK_TCPIP_CORE() rather than these
if they are a dead end?


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?52770>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/