|
From: | Simon Goldschmidt |
Subject: | [lwip-devel] [bug #52937] raw_input() must tell ip4/6_input() whether this protocol has been received |
Date: | Mon, 22 Jan 2018 11:40:24 -0500 (EST) |
User-agent: | Mozilla/5.0 (Linux; Android 6.0; LG-H815 Build/MRA58K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.111 Mobile Safari/537.36 |
Follow-up Comment #13, bug #52937 (project lwip): Let's talk about what we want to achieve, not how. - 'eaten' means 'delivered', 'packet handled' and 'pbuf freed' - 'delivered' means the ip protocol has been matched. This suppresses ICMP for unknown protocols but does not prevent pbufs for tcp, udp or igmp etc being delivered to the real protocol stack This patch seems to fix unknown ip protocols only. There's nothing wrong with that. It doesn't mean any other change. We should have a separate discussion whether changes to the raw recv callback are required. I'd still favour a return code over an additional argument though. _______________________________________________________ Reply to this item at: <http://savannah.nongnu.org/bugs/?52937> _______________________________________________ Message sent via/by Savannah http://savannah.nongnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |